arch/sim: Update defconfig for NXWM and disable CONFIG_NSH_ARCHINIT #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of changes Disable CONFIG_NSH_ARCHINIT to prevent the boardctl() logic to call multiple times the oneshot_register() function. The boardctl logic is already called from nxwm_main. Signed-off-by: Sebastian Ene <sene@apache.org>
xiaoxiang781216
approved these changes
Oct 31, 2020
Member
|
@xiaoxiang781216 This one needs to be backported? |
Contributor
|
Yes, we need backport this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2093
Summary of changes
This patch addresses the first issue described in the linked ticket:
incubator-nuttx-appsfixes the issue with the crash: arch/sim: Fix NXWM test failure nuttx-apps#456Disable CONFIG_NSH_ARCHINIT to prevent the boardctl() logic to call
multiple times the oneshot_register() function. The boardctl logic is
already called from nxwm_main.
Testing
Verified that the error message:
ERROR: Failed to register oneshot at /dev/oneshot: -17is no longer shown during simulation start.
Signed-off-by: Sebastian Ene sene@apache.org