-
Notifications
You must be signed in to change notification settings - Fork 1.4k
arch/xtensa/esp32[-s3]: Add ULP RISCV coprocessor wakeup #17237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch/xtensa/esp32[-s3]: Add ULP RISCV coprocessor wakeup #17237
Conversation
Fix exception issue when PM and DEBUG_ASSERTIONS enabled for esp32 and esp32s3. This error happens due to PM system workflow, when system gets into sleep-modes with removing PM_NORMAL count, system is raising an exception for not having enough number of PM_NORMAL state count if DEBUG_ASSERTIONS enabled. Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
Add ULP RISCV coprocessor wakeup support for esp32s3 Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
Add ULP RISC-V coprocessor wakeup board support for esp32s3 Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eren-terzioglu suggestion: please include the test example in to Documentation/ and explain the steps to test it. This way people could use this feature easily
ULP example has only one line difference than documentation which is mentioned on Kconfig option and defconfig doc. Also PM defconfig doc should include tricks to let device sleep. Should we add it? I thought it will be unnecessary repeating. |
Is this only one line necessary to get ULP working correctly on NuttX? If so I think it is important to document it, even if you decide not to include this sample source code. |
Only different line is |
|
Thanks @acassis, updated |
5c0e239 to
cb85df1
Compare
Add ULP RISCV coprocessor wakeup docs for esp32s3 Signed-off-by: Eren Terzioglu <eren.terzioglu@espressif.com>
Note: Please merge #17235 first
Summary
Add ULP RISC-V coprocessor wakeup board support for esp32s3
Add ULP RISCV coprocessor wakeup support for esp32s3
Impact
Impact on user: Yes, ULP RISC-V coprocessor can wake up HP core
Impact on build: No
Impact on hardware: No
Impact on documentation: No
Impact on security: No
Impact on compatibility: No
Testing
esp32s3-devkit:pmused as a base with these options added:To test this feature an example created, here are the snippets:
Building
NuttX build process applied to related config. Assuming we updated
pmconfig with related optionsRunning
Example run
Results
Device should got into sleep and nsh would be unresponsive for a few seconds but it needs to return back less than 25 seconds (or whatever assigned to
CONFIG_PM_SLEEP_WAKEUP_SEC)