system/settings: fix assertion triggered by uninitialized variables #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix non-NULL pointer assertion in `get_setting()` caused by uninitialized pointer variables. Signed-off-by: Jean THOMAS <jean@lambdaconcept.com>
xiaoxiang781216
approved these changes
Jun 25, 2025
|
CI failed due to network errors, could you please retry sim-02? Thanks. |
|
CI restarted :-) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix non-NULL pointer assertion in
get_setting()caused by uninitialized pointer variables.Summary
system/settings'
get_setting()function performs non-NULL assertion on non-initialized variables, triggering assertions.See #3107 for more details.
Impact
Fix a bug causing system/settings to be unusable.
Testing
Tested on a private project making use of
system/settingson NuttX 12.9.0.