Skip to content

system/fastboot: release resource & disconnect usbdev if need #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JianyuWang0623
Copy link
Contributor

Summary

Add disconnection for usb transport and remove interest list for epoll.

  1. Disconnect usbdev when deinit USB transport.
  2. Remove fds from the interest list and close epoll if need.

Impact

  • system/fastboot

Testing

CI

Remove fds from the interest list and close epoll if need.

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
jerpelea
jerpelea previously approved these changes Jun 24, 2025
cederom
cederom previously approved these changes Jun 24, 2025
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JianyuWang0623 :-)

@JianyuWang0623 JianyuWang0623 force-pushed the br_wjy_system_fastboot_release_resource_250624 branch from 98f1b01 to 8c87015 Compare June 24, 2025 13:05
Disconnect usbdev when deinit USB transport.

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@JianyuWang0623 JianyuWang0623 force-pushed the br_wjy_system_fastboot_release_resource_250624 branch from 8c87015 to e4c4a50 Compare June 24, 2025 16:33
Fix typos of sparse header comments and download/upload response error log.

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@cederom
Copy link
Contributor

cederom commented Jun 25, 2025

Hmm, there is build error in e4c4a50 on the commits list, but the summary on the PR shows "all checks passed", looks like CI/GH problem? I have restarted failed process hope that helps :-)

Rebuild here failed.. looks like this X status comes from build from the commit source repo? First time see that here :-P

Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JianyuWang0623 :-)

@JianyuWang0623
Copy link
Contributor Author

Hmm, there is build error in e4c4a50 on the commits list, but the summary on the PR shows "all checks passed", looks like CI/GH problem? I have restarted failed process hope that helps :-)

@cederom The new commit "system/fastboot: fix typos of response error log" has fixed the error.

../nuttx/tools/checkpatch.sh -c -u -m -g ee33688acadec76dd85b7d9ed3cba2d49e237a85..HEAD
/home/runner/work/nuttx-apps/nuttx-apps/apps/system/fastboot/fastboot.c:112: higer ==> higher
/home/runner/work/nuttx-apps/nuttx-apps/apps/system/fastboot/fastboot.c:655: Reponse ==> Response
/home/runner/work/nuttx-apps/nuttx-apps/apps/system/fastboot/fastboot.c:946: Reponse ==> Response
Error: Process completed with exit code 1.

@JianyuWang0623 JianyuWang0623 requested a review from jerpelea June 25, 2025 03:22
@jerpelea jerpelea merged commit c4ff19a into apache:master Jun 25, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants