sync the change from nuttx/.github folder #3103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xiaoxiang781216 Why are you synchronizing everything from nuttx repository ? Ok .github/ISSUE_TEMPLATE/001_bug_report.yml Not necessary .github/nxstyle.json nuttx-apps/.github/workflows/check.yml Line 46 in 6afed10 .github/gcc.json nuttx-apps/.github/workflows/build.yml Line 174 in 6afed10 |
dropped, thanks. |
* We do not have "Settings" tab in the Apache's owned repository, thus we need to update .asf.yaml file with repository settings. * No direct push to master branch is possible. * Require status checks to pass before merge. * Setup reviews parameters. * Require signatures. * Require conversation resolution. * Require linear history. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
* Strict master branch protection requires all PR to be in sync with latest master even if changes are not related and there are no conflicts. * Because we have lots of daily merges this blocks most of the PRs as they are forced to be rebased on top of current master. * This also causes unnecessary automatic CI rebuild of each rebase. * Therefore we are setting strict status checks setting to false. * required_signatures in github means not only `git commit -s` but also cryptographic signature which is not required by us, setting false. * Disable "contexts" checks enforcement, that cause CI problems, mark TODO. References: https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
* Update CONTRIBUTING.md guide with hints and examples. * Minor GitHub Pull Request Template update hinting expected information. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
* Fix CONTRIBUTING.md github link reference. * Full URL is provided to avoid relative/fork reference issues. * Minor update on full contributing documentation. Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
Config multi line output to mode 3, so isort and black can agree with
each other:
```
3 - Vertical Hanging Indent
from third_party import (
lib1,
lib2,
lib3,
lib4,
)
```
Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
since black and flake8 disagree on code style: pyvista/pyvista#5591 Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
…rtial Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
lupyuen
approved these changes
Jun 24, 2025
cederom
approved these changes
Jun 24, 2025
jerpelea
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many improvement apply only to nuttx repo, this pr bring up all to apps repo.
Impact
app's ci workflow is same as nuttx git now.
Testing
ci