-
Notifications
You must be signed in to change notification settings - Fork 648
system/fastboot: Enable USB and TCP at the same time #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xiaoxiang781216
merged 4 commits into
apache:master
from
JianyuWang0623:br_wjy_system_fastboot_tcp_usb_same_time_250619
Jun 23, 2025
Merged
system/fastboot: Enable USB and TCP at the same time #3101
xiaoxiang781216
merged 4 commits into
apache:master
from
JianyuWang0623:br_wjy_system_fastboot_tcp_usb_same_time_250619
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3f55ba
to
8e5dbbd
Compare
@JianyuWang0623 let's change "lckfb-szpi-esp32s3:fastboot" to enable both transport too. |
Rename argument "context" to "ctx" for all functions. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Switch from poll() to epoll(). Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
8e5dbbd
to
23f776c
Compare
Add support for enabling USB and TCP transport at the same time. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
23f776c
to
288cfdc
Compare
@xiaoxiang781216 Done, and also done for the well known "esp32s3-devkit", could you review the pull request please? apache/nuttx#16562 |
Add TCP backlog dependence for poll(), network related configurations referenced to may has not enable it, without which the TCP handshake will fail. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
6f80eab
to
edd39d9
Compare
xiaoxiang781216
approved these changes
Jun 20, 2025
jerpelea
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for enabling USB and TCP transport at the same time, as subtask of #3098 (comment).
Logic of AOSP/fastboot(fastboot_device.cpp#117):
Please see the "Testing" below for more details.
And ignore space change may be eaiser to review, thanks.
Impact
Testing
Selftest
Below are test records (of the same time) of "lckfb-szpi-esp32s3:fastboot" with both TCP and USB transport enabled: