wamr: Add a new option to custom stack guard size #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
xiaoxiang781216
approved these changes
Aug 10, 2022
yamt
added a commit
to yamt/incubator-nuttx-apps
that referenced
this pull request
Dec 25, 2023
using 0 by default seems a bit too aggressive to me. 1024 here is what would have been used before this kconfig knob was introduced by apache#1259. It also matches some expectations in the recent wamrc. https://github.com/bytecodealliance/wasm-micro-runtime/blob/40b430fd240ad45f5c7a7dd0239fa2425e7c294e/core/iwasm/compilation/aot_emit_aot_file.c#L2672-L2678
yamt
added a commit
to yamt/incubator-nuttx-apps
that referenced
this pull request
Jan 19, 2024
using 0 by default seems a bit too aggressive to me. 1024 here is what would have been used before this kconfig knob was introduced by apache#1259. It also matches some expectations in the recent wamrc. https://github.com/bytecodealliance/wasm-micro-runtime/blob/40b430fd240ad45f5c7a7dd0239fa2425e7c294e/core/iwasm/compilation/aot_emit_aot_file.c#L2672-L2678
jerpelea
pushed a commit
that referenced
this pull request
Jan 19, 2024
using 0 by default seems a bit too aggressive to me. 1024 here is what would have been used before this kconfig knob was introduced by #1259. It also matches some expectations in the recent wamrc. https://github.com/bytecodealliance/wasm-micro-runtime/blob/40b430fd240ad45f5c7a7dd0239fa2425e7c294e/core/iwasm/compilation/aot_emit_aot_file.c#L2672-L2678
mlyszczek
pushed a commit
to mlyszczek/incubator-nuttx-apps
that referenced
this pull request
Feb 27, 2024
using 0 by default seems a bit too aggressive to me. 1024 here is what would have been used before this kconfig knob was introduced by apache#1259. It also matches some expectations in the recent wamrc. https://github.com/bytecodealliance/wasm-micro-runtime/blob/40b430fd240ad45f5c7a7dd0239fa2425e7c294e/core/iwasm/compilation/aot_emit_aot_file.c#L2672-L2678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reserve some space in stack as guard to detect stack overflow, use stack base by default but may not safe enough.
See also : bytecodealliance/wasm-micro-runtime#1368
Impact
New option
Testing
Custom board