Skip to content

NIFI-14435 - FlowComparator should offer deep recursive comparison #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Apr 9, 2025

Summary

NIFI-14435 - FlowComparator should offer deep recursive comparison

Follow up of reverted PR #9848.

Instead of instantiating an empty versioned process group which causes a class cast exception, we just call the compare methods for the components as well as for the configuration of the PG (only in the case of a newly added PG) to check if the defaults have changed.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @pvillard31. The latest version looks good in general, but I pushed a change to trigger the system tests workflow for changes to the nifi-registry-flow-diff module to ensure current and future updates work at the system level.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the following system test is failing based on unexpected differences.

JoinClusterWithDifferentFlowIT.testStartupWithDifferentFlow » Timeout testStartupWithDifferentFlow() timed out after 5 minutes

@pvillard31
Copy link
Contributor Author

Thanks @exceptionfactory - I have pushed a commit to address the system test failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants