Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13905 - NiFi CLI - support for new Registry Clients #9472

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Oct 30, 2024

Summary

NIFI-13905 - NiFi CLI - support for new Registry Clients

  • Added support for giving a branch name in pg-import
  • Removed the mandatory url argument for create-reg-client
  • Removed the mandatory url argument for get-reg-client
  • Removed the mandatory url argument for update-reg-client
  • Added new command set-reg-client-property to configure a registry client
  • Added Registry Client Type in the output of list-reg-clients

Steps to add a GitHub Registry Client and import flows using it:

./bin/cli.sh nifi create-reg-client -p nifi-cli.properties -rcn GitHubRegClient -rct org.apache.nifi.github.GitHubFlowRegistryClient

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi set-reg-client-property -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -prna "Authentication Type" -prva PERSONAL_ACCESS_TOKEN

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi set-reg-client-property -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -prna "Repository Owner" -prva xxx

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi set-reg-client-property -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -prna "Repository Name" -prva yyy

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi set-reg-client-property -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -prna "Personal Access Token" -prva zzz

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi set-reg-client-property -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -prna "Repository Path" -prva "buckets"

dd0aa635-0192-1000-2ee5-eb1ccc20d5c3

./bin/cli.sh nifi pg-import -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -b bucket1 -f test -fv 871acd74da8e997d4025ba8209e36ba170917f7e

dd1f4bba-0192-1000-8626-4b0b1dc4ebc5

./bin/cli.sh nifi pg-import -p nifi-cli.properties -rcid dd0aa635-0192-1000-2ee5-eb1ccc20d5c3 -b bucket1 -f test -fb dev -fv e0502f4d2cff81a283eac2426b8d60c61ea2915b

dd24e552-0192-1000-5e79-134632cf74ba

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31
Copy link
Contributor Author

Rebased after the merge of #9522

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31, these changes are helpful in light of the new Registry Clients. +1 merging

@exceptionfactory exceptionfactory merged commit 6f941bd into apache:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants