Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13937 - NiFi CLI - Add command pg-empty-queues #9459

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Oct 28, 2024

Summary

NIFI-13937 - NiFi CLI - Add command pg-empty-queues

./bin/cli.sh nifi pg-empty-queues -p nifi-cli.properties -pgid 9a70ab3e-0192-1000-af96-cd5914b70181
./bin/cli.sh nifi pg-empty-queues -p nifi-cli.properties -pgid b5e0eb3a-0192-1000-6996-53ab1c85211b --verbose
Emptying queues, currently at 0% (1 of 20)...
Emptying queues, currently at 23% (2 of 20)...
Emptying queues, currently at 50% (3 of 20)...
Emptying queues, currently at 79% (4 of 20)...
Drop request completed. Deleted: 484,282 / 0 bytes

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @pvillard31, the implementation looks good with the bounded status checks for emptying queues. +1 merging

@exceptionfactory exceptionfactory merged commit 852f3a2 into apache:main Oct 28, 2024
6 checks passed
@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants