Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIFI-13226] - Support changing color of processors and labels #8836

Merged
merged 2 commits into from
May 16, 2024
Merged

[NIFI-13226] - Support changing color of processors and labels #8836

merged 2 commits into from
May 16, 2024

Conversation

rfellows
Copy link
Contributor

@rfellows rfellows added the new ui Pull requests for work relating to the new user interface being developed. label May 15, 2024
@scottyaslan
Copy link
Contributor

reviewing...

scottyaslan
scottyaslan requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@scottyaslan scottyaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall works well. I left a few comments about the padding of the icon.

...src/app/pages/flow-designer/ui/canvas/change-color-dialog/change-color-dialog.component.scss Outdated Show resolved Hide resolved
...src/app/pages/flow-designer/ui/canvas/change-color-dialog/change-color-dialog.component.html Show resolved Hide resolved
scottyaslan
scottyaslan approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@scottyaslan scottyaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfellows these changes are really nice. I like that we can unset the color too. I will merge once CI completes.

@scottyaslan scottyaslan merged commit 60112f2 into apache:main May 16, 2024
5 checks passed
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
@rfellows @shubhluck
[NIFI-13226] - Support changing color of processors and labels (apach…
1c2196f 
…e#8836)

* [NIFI-13226] - Support changing color of processors and labels

* style the processor icon for better support cross-themes

This closes apache#8836
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
@rfellows @shubhluck
[NIFI-13226] - Support changing color of processors and labels (apach…
238c536 
…e#8836)

* [NIFI-13226] - Support changing color of processors and labels

* style the processor icon for better support cross-themes

This closes apache#8836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottyaslan scottyaslan scottyaslan approved these changes

Assignees
No one assigned
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfellows @scottyaslan