NIFI-13092: Adding info icons to configuration dialogs #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactoring TextToolTip input to be a string.
- Migrating existing info tooltips to use the NiFi tooltip and fa-info-circle icon.
- Adding info icons to configuration dialogs where necessary.
mcgilman
added
the
new ui
- Aligning Run Schedule form label between Reporting Tasks and Processors.
- Removing primary color from info icons outside of those that appear in tables.
rfellows
requested changes
Apr 24, 2024
...-designer/ui/canvas/items/process-group/edit-process-group/edit-process-group.component.html
Outdated
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html
Outdated
Show resolved
Hide resolved
...nifi/src/app/pages/flow-designer/ui/canvas/items/port/create-port/create-port.component.html
Outdated
Show resolved
Hide resolved
...mmon/controller-service/disable-controller-service/disable-controller-service.component.html
Outdated
Show resolved
Hide resolved
- Addressing review feedback.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* NIFI-13092: - Refactoring TextToolTip input to be a string. * NIFI-13092: - Migrating existing info tooltips to use the NiFi tooltip and fa-info-circle icon. * NIFI-13092: - Adding info icons to configuration dialogs where necessary. * NIFI-13092: - Aligning Run Schedule form label between Reporting Tasks and Processors. * NIFI-13092: - Removing primary color from info icons outside of those that appear in tables. * NIFI-13092: - Addressing review feedback. This closes apache#8696
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* NIFI-13092: - Refactoring TextToolTip input to be a string. * NIFI-13092: - Migrating existing info tooltips to use the NiFi tooltip and fa-info-circle icon. * NIFI-13092: - Adding info icons to configuration dialogs where necessary. * NIFI-13092: - Aligning Run Schedule form label between Reporting Tasks and Processors. * NIFI-13092: - Removing primary color from info icons outside of those that appear in tables. * NIFI-13092: - Addressing review feedback. This closes apache#8696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-13092: