-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-12960 Added ability to read password-protected Excel spreadsheets. #8658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @dan-s1, I will review this soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this feature improvement @dan-s1! The general implementation looks straightforward. I raised one question on the property naming.
...ndles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/excel/ExcelReader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adjustments @dan-s1, the latest version looks good. +1 merging and backporting.
This closes apache#8658 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This closes apache#8658 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-12960
In order to test this feature a password protected Excel spreadsheet is created in memory. This is in order to avoid potential issues with virus scanners which will quarantine such a file. In order to test an in memory Excel spreadsheet the underlying API com.github.pjfanning excel-streaming-reader had to be configured not to use temp files (which otherwise would have the same issue of being quarantined by virus scanners).
This PR is specifically for the 2.x branch but I am requesting this be back ported to the 1.x branch if possible otherwise I will open another PR.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation