-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements #8627
Merged
Merged
General improvements #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rfellows
commented
Apr 10, 2024
- NIFI-13000 - Improvement - Prevent text selection in header, flow status, canvas, extension creation dialog table.
- NIFI-13024 - Improvement - Support Enter to create selected extension type
- NIFI-13023 - Fix - Right click on canvas while search results open shows browser right-click menu
- NIFI-13018 - Fix - Refreshing Node Status History when open for the cluster, makes the incorrect backend call
- NIFI-13021 - Fix - Status History dialog changes size when switching selected metric
…g selected metric
… cluster, makes the incorrect backend call
…shows browser right-click menu
…tatus, canvas, extension creation dialog table.
b052a96
to
8f552a4
Compare
scottyaslan
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few color issues:
...rontend/src/main/nifi/src/app/ui/common/extension-creation/extension-creation.component.html
Outdated
Show resolved
Hide resolved
...rontend/src/main/nifi/src/app/ui/common/extension-creation/extension-creation.component.html
Outdated
Show resolved
Hide resolved
…atus history charts
scottyaslan
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge once CI completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.