[NIFI-12537] Open cluster/node dialog from Summary screen. #8454
Conversation
rfellows
added
the
new ui
|
Will review... |
There was a problem hiding this comment.
Nice work @rfellows! The shared filter component and base class for the cluster status table nicely avoid repeated boilerplate as much as possible. I did notice a couple of things detailed below and a separate observation that affects all tables. As I was verifying the sort (and multi-sort) capabilities and clicking on the headers the text kept selecting. I'd be interested to get your thoughts on possibly disabling that by setting user-select: none for all mat-sort-header-content in the base styles.scss.
| } | ||
| }); | ||
| }), | ||
| catchError((error) => of(this.errorHelper.handleLoadingError(error.error, error))) |
There was a problem hiding this comment.
I don't think we want to be using handleLoadingError here. I think we probably want to check the error and see if it should be shown in context and then either use a snackbar or full screen. handlingLoadingError accepts an argument that is the current store status and uses that as part of the logic to determine how to sure the error message.
| } | ||
| }); | ||
| }), | ||
| catchError((error) => of(this.errorHelper.handleLoadingError(error.error, error))) |
| private _clusterNodes: NodeSearchResult[] | null = null; | ||
| private _selectedClusterNode: NodeSearchResult | null = null; | ||
| private _selectedId: string | null = null; | ||
| private currentFilter: SummaryTableFilterContext | null = null; |
There was a problem hiding this comment.
This doesn't appear to be used (though maybe I missed it).
I agree. We have many issues in the app allowing too much text selection. I can add this to the base listing table style since it happens so regularly when just clicking on the headers to sort them. |
…nel no longer wraps, shorted the dropdown width as well.
NIFI-12537