Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12060 Remove Groovy Tests using Spock Framework #7694

Closed
wants to merge 1 commit into from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-12060 Removes Groovy unit tests that use the Spock Framework and adds org.spockframework to the list of banned dependencies.

In addition to removing several other Groovy-based unit tests and associated build profiles, these changes streamline general repository maintenance and limit remaining Groovy references to the encrypt-config toolkit module.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added org.spockframework to the list of banned dependencies
- Removed several other Groovy tests and associated build profiles
@joewitt
Copy link
Contributor

joewitt commented Sep 14, 2023

Much good cleaning. Running the full blown build now. If good will merge. I'll then update my groovy 4.0.15 PR on top of this.

@asfgit asfgit closed this in 98fa7d0 Sep 14, 2023
exceptionfactory added a commit that referenced this pull request Sep 14, 2023
- Added org.spockframework to the list of banned dependencies
- Removed several other Groovy tests and associated build profiles

Signed-off-by: Joseph Witt <joewitt@apache.org>

(cherry picked from commit 98fa7d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants