-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-11706 Add capability to create dedicated Parameter Contexts for versioned flows when importing #7401
Conversation
…versioned flows when importing
import java.util.stream.Stream; | ||
|
||
|
||
class ParameterContextNameCollusionResolverTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling correction:
class ParameterContextNameCollusionResolverTest { | |
class ParameterContextNameCollisionResolverTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this improvement @simonbence. The general concept makes sense. I noted some spelling issues, and raised a concern about using a boolean
versus an enum
, which would support future options, and also help clarify the implementation default and optional behavior.
.../nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/import-flow-version-dialog.jsp
Outdated
Show resolved
Hide resolved
...k-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-flow-version.js
Outdated
Show resolved
Hide resolved
...fi-web-api/src/main/java/org/apache/nifi/web/util/ParameterContextNameCollusionResolver.java
Outdated
Show resolved
Hide resolved
...fi-web-api/src/main/java/org/apache/nifi/web/util/ParameterContextNameCollusionResolver.java
Outdated
Show resolved
Hide resolved
...fi-web-api/src/main/java/org/apache/nifi/web/util/ParameterContextNameCollusionResolver.java
Outdated
Show resolved
Hide resolved
...mework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Outdated
Show resolved
Hide resolved
...mework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Outdated
Show resolved
Hide resolved
.../nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/import-flow-version-dialog.jsp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adjustments @simonbence, the latest version looks good. +1 merging
Summary
NIFI-11706
(Test scenarios helping to understand and review the changes are added as comment on the ticket)
As many Versioned Flows are imported multiple times but used with in somewhat different circumstances (such as: different endpoints, databases, etc.), it would make sense to give the user the possibility to import flows in a way that their Parameter Context become independent from the other instances. In order to achieve this a new checkbox will be added to the Import Version window which makes it possible to decide for the user if she wants to keep the existing Parameter Contexts (bounding the parameters to the potentially existing instances) or she wants to create a new set of Parameter Contexts making the flow parametrised independently.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation