Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6861 - Added missing display name property for InfluxDB max connection timeout #3882

Closed
wants to merge 1 commit into from
Closed

NIFI-6861 - Added missing display name property for InfluxDB max connection timeout #3882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NIFI-6861 - Added missing display name property
  • Loading branch information
@mans2singh
mans2singh committed Nov 11, 2019
commit 33e94a8bade6895dbe0dfb35b2ffd7042802897e
3 changes: 2 additions & 1 deletion ...ocessors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public abstract class AbstractInfluxDBProcessor extends AbstractProcessor {
.build();

public static final PropertyDescriptor INFLUX_DB_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
.name("InfluxDB Max Connection Time Out (seconds)")
.name("influxdb-max-connection-time-out")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I think we don't want this change to happen. As soon as a processor is released, changing the .name() property would be a breaking change for existing flows with this processor. I think we might want to revisit all the processor for a 2.0 release but it'd need to be discussed and we would need to provide tools for a proper migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, please keep the name the same but update displayName, that should give you what you want without breaking existing processors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to merge and just remove the name line while keeping displayName

.displayName("InfluxDB Max Connection Time Out (seconds)")
.description("The maximum time for establishing connection to the InfluxDB")
.defaultValue("0 seconds")
.required(true)
Expand Down