Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

NIFIREG-387 - Upgraded spring boot and some additional depedencies re… #277

Closed
wants to merge 2 commits into from

Conversation

thenatog
Copy link
Contributor

…quired to allow this upgrade.

pom.xml Outdated
<jackson.version>2.9.9</jackson.version>
<jackson.databind.version>2.9.10.3</jackson.databind.version>
<spring.boot.version>2.1.12.RELEASE</spring.boot.version>
<spring.boot.version>2.2.6.RELEASE</spring.boot.version>
<spring.security.version>5.1.8.RELEASE</spring.security.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like spring security can be bumped to along with the new version of spring-framework, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 5.1.9.RELEASE.

Copy link
Contributor

@kevdoran kevdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @thenatog. Are any changes to our NOTICE file required? Not sure if any of these are called out by version number there.

pom.xml Outdated
Comment on lines 99 to 100
<jackson.version>2.9.9</jackson.version>
<jackson.databind.version>2.9.10.3</jackson.databind.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like jackson can go to 2.10.3. also not sure why we are at separate versions for jackson and jackson databank

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 2.10.3 and removed the jackson.databind.version parameter and changed all dependencies to use only jackson.version.

@thenatog
Copy link
Contributor Author

Update the NOTICE file.

@alopresto
Copy link
Contributor

@kevdoran did you need another look at this or were updating the NOTICE file and going to 2.10.3 the only reservations you had?

@kevdoran
Copy link
Contributor

Hey @alopresto @thenatog - sorry, this one fell off my radar. That was all I had. +1 from me. Thanks!

@thenatog thenatog closed this in 2881e29 May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants