MINIFICPP-2683 Move C2 docker tests to modular docker tests#2089
Open
lordgamez wants to merge 1 commit intoapache:mainfrom
Open
MINIFICPP-2683 Move C2 docker tests to modular docker tests#2089lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez wants to merge 1 commit intoapache:mainfrom
Conversation
8 tasks
c85588c to
9078384
Compare
23f0367 to
544f99c
Compare
9078384 to
05ba7b1
Compare
szaszm
approved these changes
Jan 30, 2026
05ba7b1 to
7037f68
Compare
fgerlits
reviewed
Feb 2, 2026
| def fetch_flow_config_from_flow_url(self): | ||
| self.properties["nifi.c2.flow.url"] = f"http://minifi-c2-server-{self.scenario_id}:10090/c2/config?class=minifi-test-class" | ||
|
|
||
| def set_up_ssl_proprties(self): |
Contributor
There was a problem hiding this comment.
typo:
Suggested change
| def set_up_ssl_proprties(self): | |
| def set_up_ssl_properties(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2683
Depends on #2078
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.