Repository navigation
Conversation
Member
|
Generally looks good.
Is there much difference with the fast path? Do we support custom paths elsewhere anyway? eg. assuming the path contains "test" might reach edge cases with things like https://maven.apache.org/whatsnewinmaven4.html#new-way-to-declare-source-directories ?? |
Member
Author
|
if you take a look at getSourceRoots and getGeneratedSourceRoots which are both called from within the if block. They build the path with |
Member
|
I already looked at them. Are you sure |
Run javac profile queries only for java 8 targets which is the only java version where profiles existed. Skip over query code in MavenSourceLevelImpl if the result value is already known.
mbien
force-pushed
the
skip-maven-sourcelevel-queries
branch
from
October 10, 2026 09:31
52ae3e5 to
648ab58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run javac profile queries only for java 8 targets which is the only java version where profiles existed.
Skip over query code in
MavenSourceLevelImplif the result value is already known.Add fast path for files outside of test dirs.