Facelift on spellchecker module - #9515
Open
lkishalmi wants to merge 1 commit into
Open
Conversation
mbien
approved these changes
Aug 7, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
looks good i think. only looked at it through github though.
Comment on lines
-315
to
+321
| if (input != null) try { input.close (); } catch (IOException e) {} | ||
| if (output != null) try { output.close (); } catch (IOException e) {} | ||
|
|
||
| if (input != null) try { | ||
| input.close(); | ||
| } catch (IOException e) { | ||
| } | ||
| if (output != null) try { | ||
| output.close(); | ||
| } catch (IOException e) { | ||
| } |
Member
There was a problem hiding this comment.
you could put the streams into an ARM block and replace the custom impl with in.transferTo(out)
Comment on lines
+462
to
+463
| Collection<String> currentLocales; | ||
| currentLocales = new HashSet<>(); |
Comment on lines
66
to
+67
| try { | ||
| r = new BufferedReader(new InputStreamReader(file.getInputStream(), UTF8)); | ||
|
|
||
| r = new BufferedReader(new InputStreamReader(file.getInputStream(), UTF_8)); |
Comment on lines
-125
to
+119
| ProjectManager.mutex().readAccess(new Action<Void>() { | ||
| public Void run() { | ||
| Element conf = ac.getConfigurationFragment(WORDLIST, NAMESPACE, true); | ||
| ProjectManager.mutex().readAccess(() -> { | ||
| Element conf = ac.getConfigurationFragment(WORDLIST, NAMESPACE, true); | ||
|
|
||
| if (conf == null) { | ||
| return null; | ||
| } | ||
|
|
||
| NodeList childNodes = conf.getChildNodes(); | ||
| if (conf == null) { | ||
| return; | ||
| } | ||
|
|
||
| for (int cntr = 0; cntr < childNodes.getLength(); cntr++) { | ||
| Node n = childNodes.item(cntr); | ||
| NodeList childNodes = conf.getChildNodes(); | ||
|
|
||
| if ("word".equals(n.getLocalName())) { | ||
| addEntryImpl(n.getTextContent()); | ||
| } | ||
| for (int cntr = 0; cntr < childNodes.getLength(); cntr++) { | ||
| Node n = childNodes.item(cntr); | ||
|
|
||
| if ("word".equals(n.getLocalName())) { | ||
| addEntryImpl(n.getTextContent()); | ||
| } | ||
| return null; | ||
| } | ||
| }); | ||
| getDictionary().sort(dictionaryComparator); | ||
|
|
||
| dictionary.sort(dictionaryComparator); |
Member
There was a problem hiding this comment.
similar to changes in loadDictionary(File source), this should probably be in a synchronized block and use the dictionary field directly. Once done, addEntryImpl() can be removed since it has no usages.
Comment on lines
79
to
+80
| FileInputStream ins = new FileInputStream(data); | ||
| FileChannel channel = ins.getChannel(); | ||
|
|
||
| try { | ||
| try (FileChannel channel = ins.getChannel()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this is one of the old code we have. Before adding HunSpell support a little facelift won't hurt.
The
SpellcheckerOptionsPanelcould see an iteration or two. The+/-prefixes in the strings in CheckboxList model bothers me. Though I wanted to avoid accidental functionality changes.The
ErrorHighlightPainterinComponentPeerbecame an instance method and used as a method reference instead of creating one instance for each miss-spelled word.I've removed the
getDictionary()method inDictionaryImplwhich was supposed to lazy initialize thedictionaryfield. Though as it was called multiple times during the construction it seems to be pretty useless.Added a few records where it made sense.