Facelift on spellchecker.bindings.htmlxml - #9508
Open
lkishalmi wants to merge 1 commit into
Open
Conversation
mbien
approved these changes
Aug 7, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
looks good, sorry for the delay
package is private so it can be freely refactored
Comment on lines
+41
to
+42
| private static final Map<String, String> MIME_TO_SETTING_NAME = Map.ofEntries( | ||
| Map.entry("text/html", "HTML"), //NOI18N |
Member
There was a problem hiding this comment.
nitpick: could use regular Map.of(k, v) since it is below 10 key-value pairs.
Member
There was a problem hiding this comment.
nothing changed in this file looks like only the dep order?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of my work on the Spellchecker. Nothing new, just modernization.
No rush, could be good for NB32...