FISH-12969 Payara Server Startup Fails in Apache NetBeans IDE Due to the CRaCCheckpointTo Option#9237
Open
jGauravGupta wants to merge 1 commit intoapache:masterfrom
Open
FISH-12969 Payara Server Startup Fails in Apache NetBeans IDE Due to the CRaCCheckpointTo Option#9237jGauravGupta wants to merge 1 commit intoapache:masterfrom
jGauravGupta wants to merge 1 commit intoapache:masterfrom
Conversation
…the CRaCCheckpointTo Option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payara Server startup may fail in Apache NetBeans when domain.xml contains
the JVM option:
-XX:CRaCCheckpointTo=...This option is only supported by CRaC-enabled JDKs. The IDE
previously filtered JVM options only by version and vendor, without checking
whether the selected JDK supports CRaC. As a result, non-CRaC JDKs failed to
start with “Unrecognized VM option” errors.
This PR enhances
JDKVersion.isCorrectJDK(...)to additionally validateCRaC-related options. CRaC options are now applied only if the selected
server JDK (javaHome) contains lib/criu, indicating CRaC support.
No changes to existing vendor/version logic. Standard JDK behavior remains
unchanged.