Skip to content

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Nov 3, 2025

Closes #8343

Before:

image

After:

image image

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@haidubogdan haidubogdan changed the title CSS include support for image-set. #8343 CSS include support for image-set Nov 3, 2025
@mbien mbien added CSS [ci] enable web job web [ci] enable web job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 3, 2025
@apache apache locked and limited conversation to collaborators Nov 3, 2025
@apache apache unlocked this conversation Nov 3, 2025
@haidubogdan haidubogdan force-pushed the t_8343_css_support_image_set branch from a7e8fc3 to ae375e9 Compare November 4, 2025 08:38
@matthiasblaesing matthiasblaesing added this to the NB29 milestone Nov 11, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you!

Minimal nitpick for the future: the commit message should have a summary line then an empty line and then the text with further information, closes/signed-off by lines etc.

@matthiasblaesing matthiasblaesing merged commit 39844dd into apache:master Nov 11, 2025
30 checks passed
@haidubogdan haidubogdan deleted the t_8343_css_support_image_set branch November 15, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) CSS [ci] enable web job web [ci] enable web job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS: support image-set

3 participants