-
Notifications
You must be signed in to change notification settings - Fork 908
Update jgit from 7.2.0 to 7.4.0 #8892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mbien
wants to merge
3
commits into
apache:master
Choose a base branch
from
mbien:jgit740
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oh right I forgot about that (#7569). bouncycaste can't be updated still
edit: reverted it here and parked the bouncycastle commit in a branch https://github.com/mbien/netbeans/commits/bc182/ |
1 task
jgit update is likely not possible with the bouncycastle dependency locked to 1.77. I ran jgit tests locally with downgraded dependency: diff --git a/pom.xml b/pom.xml
index 14cfa2405..f1a8b742c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -137,7 +137,7 @@
<slf4j-version>1.7.36</slf4j-version>
<maven-javadoc-plugin-version>3.11.2</maven-javadoc-plugin-version>
<gson-version>2.13.1</gson-version>
- <bouncycastle-version>1.81</bouncycastle-version>
+ <bouncycastle-version>1.77</bouncycastle-version>
<spotbugs-maven-plugin-version>4.9.3.0</spotbugs-maven-plugin-version>
<maven-project-info-reports-plugin-version>3.9.0</maven-project-info-reports-plugin-version>
<maven-jxr-plugin-version>3.6.0</maven-jxr-plugin-version>
failed with
converting to draft, dropping milestone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:dev-build
[ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page)
do not merge
Don't merge this PR, it is not ready or just demonstration purposes.
git
[ci] enable versioning job
Upgrade Library
Library (Dependency) Upgrade
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates jgit to latest (7.4) and its dependencies to the resolved version.
current jgit releases are not on maven central yet but the jgit team is working on it (eclipse-jgit/jgit#210). This adds the eclipse repo temporarily.doneclasspath diffs
thanks to @cstamas for the awesome classpath diff tool. This made this much easier than in past.
last update for reference #8383