Skip to content

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 7, 2025

Consider code like:

package test;

import java.util.List;

public class JavaApplication113 {

    public List<String> test(String str) {
        return null;
    }

    public static class SubClass extends JavaApplication113 {

        @Override
        public java.util.List<java.lang.String> test(java.lang.String str) {
            return null;
        }
        
    }
}

put cursor at JavaApplication113.test, open the Refactor/Change Method Parameters, and add a new parameter with type java.util.List<java.lang.String> and name par1. The refactoring will use java.util.List<java.lang.String> as the parameter type that is written in the source code. I think imports should be properly resolved on every place where the type is printed, and typically java.util.List should be imported, and the inserted type should be List<String>.

This is what this PR is attempting to do.

@lahodaj lahodaj added this to the NB27 milestone Jul 7, 2025
@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension labels Jul 7, 2025
@ebarboni ebarboni modified the milestones: NB27, NB28 Jul 23, 2025
shivam71 added a commit to shivam71/javavscode that referenced this pull request Aug 18, 2025
Minor change in the original patch
line 76
'-spec.version.base=1.91.0'
changed to
'-spec.version.base=1.89.0'
the above change require as our netbeans 25 currently was on refactoring api version 1.89.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants