-
Notifications
You must be signed in to change notification settings - Fork 916
Add open containing folder and open in tab actions. #7081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
03eaec4 to
0a0839e
Compare
|
removed milestone |
0a0839e to
0b2a4e5
Compare
|
As the title says "open containing folder" this is my suggestion to add it like this. |
|
I originally had this in mind but I am still trying to find a place for another action: "Open Folder in NetBeans" To deconflict this we would have to call it "Open Containing Folder in System" which is quite long. So I picked "Open Parent in System" which is concise and still manages to describe exactly what it does. The other option is to use sub-menus, the problem there is that this would be 3 layers in some situations, which I would like to avoid if possible. |
|
Open Folder in NetBeans could also called "Open Folder as Project" or smth like that. It has a different context, but I'm fine with it then. |
|
Open Folder in NetBeans (which can also open jars, who knows what else it can open) would not be the same as open project |
|
I know I already implemented this as a 3rd party plugin, but to make it clear I call it "Open Folder as Project". Because it will be shown in the project tabs. It has not all functions that a project has, but this makes it more clear IMHO. I know via CLI you can open Folder in NetBeans, which will open a folder within a new TopComponent. Is this what you mean and want to do? Anyway, it is out of scope for this ticket and we can discuss the other stuff in another PR or via discussion. At the end, I'm fine with it, the wording in some cases in NetBeans is in my opinion not often as clear as I already told it but it is better than nothing. |
extracted AbstractOpenInAction as common superclass for - (old) OpenInSystemAction - (new) OpenParentInSystemAction - (new) Open(Parent)InTabAction
0b2a4e5 to
0390b02
Compare
|
refreshed this PR as POC. Its now 4 actions. This is too much for the context menus atm (esp for the project menu), so we would have to identify items which belong together and move them around a bit if we want to expand the functionality. |
like open-in-system but opens the parent + open-in-tab actions
extracted AbstractOpenInAction as common superclass for