Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Feb 19, 2024

like open-in-system but opens the parent + open-in-tab actions

extracted AbstractOpenInAction as common superclass for

  • (old) OpenInSystemAction
  • (new) OpenParentInSystemAction
  • (new) Open(Parent)InTabAction

@mbien mbien added UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Feb 19, 2024
@mbien mbien added this to the NB22 milestone Feb 19, 2024
@mbien mbien force-pushed the open-parent-folder branch from 03eaec4 to 0a0839e Compare February 19, 2024 01:34
@mbien mbien removed this from the NB22 milestone Apr 17, 2024
@mbien
Copy link
Member Author

mbien commented Apr 17, 2024

removed milestone

@mbien mbien added this to the NB24 milestone Oct 9, 2024
@mbien mbien added the Upgrade JDK Upgrade to the JDK requirements of a module. label Oct 9, 2024
@mbien mbien force-pushed the open-parent-folder branch from 0a0839e to 0b2a4e5 Compare October 9, 2024 22:05
@mbien mbien marked this pull request as ready for review October 9, 2024 22:05
@mbien mbien requested a review from neilcsmith-net October 9, 2024 22:10
@Chris2011
Copy link
Contributor

As the title says "open containing folder" this is my suggestion to add it like this.

@mbien
Copy link
Member Author

mbien commented Oct 10, 2024

I originally had this in mind but I am still trying to find a place for another action: "Open Folder in NetBeans"

To deconflict this we would have to call it "Open Containing Folder in System" which is quite long. So I picked "Open Parent in System" which is concise and still manages to describe exactly what it does.

The other option is to use sub-menus, the problem there is that this would be 3 layers in some situations, which I would like to avoid if possible.

@Chris2011
Copy link
Contributor

Open Folder in NetBeans could also called "Open Folder as Project" or smth like that. It has a different context, but I'm fine with it then.

@mbien
Copy link
Member Author

mbien commented Oct 10, 2024

Open Folder in NetBeans (which can also open jars, who knows what else it can open) would not be the same as open project

@Chris2011
Copy link
Contributor

I know I already implemented this as a 3rd party plugin, but to make it clear I call it "Open Folder as Project". Because it will be shown in the project tabs. It has not all functions that a project has, but this makes it more clear IMHO. I know via CLI you can open Folder in NetBeans, which will open a folder within a new TopComponent. Is this what you mean and want to do?

Anyway, it is out of scope for this ticket and we can discuss the other stuff in another PR or via discussion. At the end, I'm fine with it, the wording in some cases in NetBeans is in my opinion not often as clear as I already told it but it is better than nothing.

@mbien mbien removed this from the NB24 milestone Oct 14, 2024
@mbien mbien marked this pull request as draft October 14, 2024 03:15
extracted AbstractOpenInAction as common superclass for

 - (old) OpenInSystemAction
 - (new) OpenParentInSystemAction
 - (new) Open(Parent)InTabAction
@mbien mbien changed the title Add open containing folder action. Add open containing folder and open in tab actions. Oct 3, 2025
@mbien mbien force-pushed the open-parent-folder branch from 0b2a4e5 to 0390b02 Compare October 3, 2025 02:19
@mbien
Copy link
Member Author

mbien commented Oct 3, 2025

refreshed this PR as POC.

Its now 4 actions. This is too much for the context menus atm (esp for the project menu), so we would have to identify items which belong together and move them around a bit if we want to expand the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) UI User Interface Upgrade JDK Upgrade to the JDK requirements of a module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants