Use the currently active dialog as the presenter parent #6216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens/incubator-netbeans into rk-dialog-parent
Update Utilities findDialogParent API to not use fallback Supplier and update docs. Update DialogDisplayerImpl to validate preferred parent. Update DialogDisplayerImplTest to stop stray modal dialog breaking parent test.
neilcsmith-net
added
the
ci:dev-build
neilcsmith-net
changed the title
mbien
reviewed
Jul 18, 2023
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
changes make sense to me. Although I have limited experience with the window parent issue.
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to #5989 by @rkeen-siemens to address comments and to check tests before we branch for NB19.
Fixes #5987