ANTLRv4 indent and code snippet support. #4800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
approved these changes
Oct 17, 2022
Member
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
looks good as far as I can tell. But I didn't "think through" the formatting code. Its been a while since I wrote an Antlr grammar.
This is also fairly low risk for inclusion. +1 for merging this before feature freeze.
java/languages.antlr/src/org/netbeans/modules/languages/antlr/v4/Antlr4CompletionProvider.java
Outdated
Show resolved
Hide resolved
java/languages.antlr/src/org/netbeans/modules/languages/antlr/v4/Antlr4Formatter.java
Show resolved
Hide resolved
Contributor
Author
|
Well, a formatter code is never nice, as far as I checked. The basic idea here is using a heuristic based on the Lexer to determine whether we are in a rule or not. While in rule, the whitespace is examined for each line break, and indent the line according to the inrule state. |
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
* Add indenting support for ANTLRv4 grammars * Removed console error listeners, fixed a couple of potential NPE-s * Added code snippets for ANTLR v4 Grammars * ANTLR indent set to 4 be default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my last round of features for ANTLR support, mainly for v4 grammars. Add indent support in rule definitions, and a few code shortcuts.
Beside of that, prevented a few of NPE-s that could happen on parsing an incomplete grammar. Also removed the ConsoleErrorListener.