-
Notifications
You must be signed in to change notification settings - Fork 914
Support for jar & native image artifact for gradle projects [3/3] #4730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c966fe1 to
ad30f56
Compare
|
Rebased on latest master. |
|
There's some issue with the tests: they fail on CI, but not locally; stay tuned. |
bd56b8d to
ce6cae2
Compare
…radle Build Properties API.
d68b4f8 to
e9eb768
Compare
|
Adding @lkishalmi - I've identified a bug in recently introduced support for task dependencies in Gradle. All gradle changes are in commit 7226aff. @ppisl, @dbalek pls review the micronaut and/or maven implementation. |
|
I think an explanation would be useful for why there were so many commits and attempts to fix a failing build. The reason is simple: I failed to create a proper test environment for the project infrastructure to work properly. The tests worked OK on a local machine all the time.
As a result, I've added a bunch of logging, which I think should remain in the code -- it will help in when one will debug project metadata loading issues in Maven. |
lkishalmi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed through.
Looks good to me.
|
One more fix -- I've realized during testing that if a (gradle) project is queried while not 'officially' opened, e.g. from a LSP client, it will report just basic structure as it does not really load the project metada through Gradle. Fixed in the LSP command impl. |
dbalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick scan of the sources. Looks good.
| - name: micronaut | ||
| run: ant $OPTS -f enterprise/micronaut test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @sdedic, i think this might have to be wrapped into .github/retry.sh + command
Since you can see it failing in unrelated PRs.
|
@sdedic please make sure milestone is set when merging, thanks! |
Note: this is the last "feature" PR - it depends on #4729. This PR will be rebased on whatever version #4729 evolves into.
The PR builds on top of
BuildPropertiesSupportAPI in Gradle core module and allows:jartask's artifacts: the project reports the produced jar