Skip to content

nimble/hci: Document vendor specific commands #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nimble/hci: Document vendor specific commands #1996

wants to merge 1 commit into from
+312 −0

Conversation

szymon-czapracki
Copy link
Contributor

Commands were not documented.
Lack of the descriptions could led
to some ambiguous interpretations.

@github-actions github-actions bot added the size/S Small PR label Feb 27, 2025
@szymon-czapracki szymon-czapracki marked this pull request as ready for review February 28, 2025 12:27
@szymon-czapracki
Copy link
Contributor Author

@sjanc FYI #1643

@szymon-czapracki szymon-czapracki changed the title [WIP] nimble/hci: Document vendor specific commands nimble/hci: Document vendor specific commands Feb 28, 2025
sjanc
sjanc reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, this should be documented in text document similarly to how HCI commands and events are specified in core spec

@github-actions github-actions bot added the size/M Medium PR label Mar 10, 2025
@szymon-czapracki szymon-czapracki marked this pull request as draft March 11, 2025 09:59
@szymon-czapracki szymon-czapracki force-pushed the vend_spec_doc branch 10 times, most recently from 76ad893 to c6b835c Compare March 21, 2025 12:35
@szymon-czapracki szymon-czapracki requested a review from sjanc March 21, 2025 12:39
@szymon-czapracki szymon-czapracki marked this pull request as ready for review March 21, 2025 12:39
@szymon-czapracki szymon-czapracki force-pushed the vend_spec_doc branch 2 times, most recently from 47bb06d to 61563ed Compare May 5, 2025 11:26
@szymon-czapracki
nimble/hci: Document vendor specific commands
3fc9b5c 
Commands were not documented.
Lack of the descriptions could led
to some ambiguous interpretations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc Awaiting requested review from sjanc

Assignees
No one assigned
Labels
size/M Medium PR size/S Small PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymon-czapracki @sjanc