nimble: tester: Implement GATT Server BTP Service (ID 0x07) #1969
+1,164
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrnarajowski
force-pushed
the
GATTS_BTP_SERVICE
branch
from
cf0fbb7 to
f2071c3
Compare
New BTP service is introduced. Most of the changes are just migration of code from btp_gatt.c and btp_gatt.h. Changes also include refactor of how notifications are sent by server: - os_callout_init and functions/variables realted to it are removed. It was responsible for starting a timer when peer has subscribed for notifications/indications and sending notifications right after the timer has expired. - An updated version of gatts_set_value command can be used to set values of one or more characteristics and takes care of sending notifications, indications and multiple handle value notifications
piotrnarajowski
force-pushed
the
GATTS_BTP_SERVICE
branch
from
f2071c3 to
03a7fa7
Compare
|
It might be good if this was parted into several commits - i.e. changes made to header files might be separated into standalone commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New BTP service is introduced. Most of the changes are just migration of code from btp_gatt.c and btp_gatt.h. Changes also include refactor of how notifications are sent by server: