Feature: Support to ask user for authorization #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjanc Please TAL |
andrzej-kaczmarek
requested changes
Dec 29, 2023
SumeetSingh19
force-pushed
the
feat/gatt_authorization
branch
from
841645f to
50eac03
Compare
|
@sjanc PTAL |
|
@Singh-Sumeet we discussed with @sjanc and we agreed that return value from callback should be used instead of event struct field. we'd also like to have an option in future to make it authorization asynchronous so the return values should be reject, accept, pending - please add appropriate macros for that. reject should be set to 0 so authorization is rejected by default. |
SumeetSingh19
force-pushed
the
feat/gatt_authorization
branch
from
50eac03 to
25808ac
Compare
|
Hi @andrzej-kaczmarek , I have made the required changes. I don't understand what you mean by making it "Authorization Asynchronous", but I have created the macro nonetheless. |
piotrnarajowski
added a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Mar 20, 2025
This introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond to GAP authorization event with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
added a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Mar 20, 2025
This introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond to GAP authorization event with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
added a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Mar 20, 2025
This introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond to GAP authorization event with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
pushed a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Mar 24, 2025
This introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond to GAP authorization event with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
pushed a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Mar 28, 2025
This commit introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
pushed a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Apr 8, 2025
This commit introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. ble_att_svr_create_foo_rsp helpers are introduced to hanldle preparing and sending ATT responses. This is done on top of PR apache#1668 by SumeetSingh19
piotrnarajowski
pushed a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Apr 9, 2025
This commit introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. ble_att_svr_create_foo_rsp helpers are introduced to hanldle preparing and sending ATT responses. This is done on top of PR apache#1668 by SumeetSingh19
SumeetSingh19
force-pushed
the
feat/gatt_authorization
branch
from
25808ac to
342788b
Compare
piotrnarajowski
pushed a commit
to piotrnarajowski/mynewt
that referenced
this pull request
Aug 7, 2025
This commit introduces handling authorization in nimble. Each operation on characteristic that has authorize flags will require authorization. Application can respond in GAP authorization event callback with accept, reject or pending response. The latter response should trigger user action to either accept or reject request and finish handling att request. ble_att_svr_create_foo_rsp helpers are introduced to hanldle preparing and sending ATT responses. This is done on top of PR apache#1668 by SumeetSingh19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to add: