newt: Add external repos patches support #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjer
approved these changes
Apr 3, 2024
sjanc
requested changes
Apr 3, 2024
There was a problem hiding this comment.
I think we should use GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL to avoid requiring git configuration by user. Also this would allow us to have 'newt' as committer ie:
GIT_COMMITTER_NAME=newt
GIT_COMMITTER_EMAIL=dev@mynewt.apache.org
| } | ||
| cmd = append(cmd, patches...) | ||
|
|
||
| _, err := executeGitCommand(repoDir, cmd, true) |
There was a problem hiding this comment.
hmm should we even try to execute 'git am' if no patches were provided?
sjanc
approved these changes
Apr 5, 2024
|
When patch fails affected git repository stays in state that |
Now if package that adds external repository contains directory patches/*external_repo_name*, newt will try to apply patches inside this directory to the external repo.
|
@kasjer Fix applied |
|
Verified to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if package that adds external repository contains directory patches/external_repo_name, newt will try to apply patches inside this directory to the external repo.