Skip to content

Commit

Permalink
ci: Add ambiguous config test
Browse files Browse the repository at this point in the history
  • Loading branch information
m-gorecki committed Aug 30, 2024
1 parent 85d67b9 commit 083b8fe
Show file tree
Hide file tree
Showing 7 changed files with 102 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/targets/ambiguous_fail/pkg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pkg.name: "targets/ambiguous_fail"
pkg.type: target
pkg.description:
pkg.author:
pkg.homepage:
10 changes: 10 additions & 0 deletions .github/targets/ambiguous_fail/syscfg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
syscfg.vals:
SHELL_PROMPT_MODULE: 1
SHELL_TASK: 1

syscfg.vals.SHELL_PROMPT_MODULE:
CONSOLE_IMPLEMENTATION: stub

# This should fail
syscfg.vals.SHELL_TASK:
CONSOLE_IMPLEMENTATION: full
3 changes: 3 additions & 0 deletions .github/targets/ambiguous_fail/target.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
target.app: "@apache-mynewt-nimble/apps/btshell"
target.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
target.build_profile: optimized
5 changes: 5 additions & 0 deletions .github/targets/ambiguous_success/pkg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pkg.name: "targets/ambiguous_success"
pkg.type: target
pkg.description:
pkg.author:
pkg.homepage:
10 changes: 10 additions & 0 deletions .github/targets/ambiguous_success/syscfg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
syscfg.vals:
SHELL_PROMPT_MODULE: 1
SHELL_TASK: 1

syscfg.vals.SHELL_PROMPT_MODULE:
CONSOLE_IMPLEMENTATION: stub

# This should not fail as it sets the same value as previous conditional config
syscfg.vals.SHELL_TASK:
CONSOLE_IMPLEMENTATION: stub
3 changes: 3 additions & 0 deletions .github/targets/ambiguous_success/target.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
target.app: "@apache-mynewt-nimble/apps/btshell"
target.bsp: "@apache-mynewt-core/hw/bsp/nordic_pca10056"
target.build_profile: optimized
66 changes: 66 additions & 0 deletions .github/workflows/test_ambiguous_cfg.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#

name: Test ambiguous config

on: [push, pull_request]

jobs:
test_ambiguous_cfg:
name: other
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 'stable'
- uses: carlosperate/arm-none-eabi-gcc-action@48db4484a55750df7a0ccca63347fcdea6534d78
with:
release: '12.2.Rel1'
- name: Install Dependencies
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install -y gcc-multilib
- name: Build newt
working-directory: newt
shell: bash
run: |
go version
go build
echo ${GITHUB_WORKSPACE}/newt >> $GITHUB_PATH
- name: Test ambiguous cfg (success)
shell: bash
run: |
newt new project
cp -r .github/targets/ambiguous_success project/targets
cd project/
newt upgrade -v
newt build ambiguous_success
- name: Test ambiguous cfg (fail)
shell: bash
run: |
cp -r .github/targets/ambiguous_fail project/targets
cd project/
! newt build ambiguous_fail &> tmp.txt
grep "Error: Setting CONSOLE_IMPLEMENTATION collision - two conditions true:" tmp.txt -q

0 comments on commit 083b8fe

Please sign in to comment.