kernel/os: Update os_assert_cb to match assert_func #3349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasjer
previously approved these changes
Nov 26, 2024
andrzej-kaczmarek
force-pushed
the
os_assert_cb-fix
branch
from
2e98136 to
7a5d512
Compare
|
|
This updates os_assert_cb prototype to match assert_func. This allows to get proper assert information in callback e.g. for logging.
andrzej-kaczmarek
force-pushed
the
os_assert_cb-fix
branch
from
7a5d512 to
1c5c876
Compare
kasjer
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates os_assert_cb prototype to match assert_func. This allows to get proper assert information in callback e.g. for logging.
Note that this breaks API, but since updates in other projects are trivial I'd like to get this merged. A good example why this is useful is a blehci app which can use os_assert_cb to log asserts system-wide via HCI vs event: apache/mynewt-nimble#1930