This repository was archived by the owner on Nov 17, 2023. It is now read-only.
fix CreateOp of altering shape operations to accept dtypes of uint8 and int32 #9569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix wrong argument y to sequence_length in api doc
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…nd int32 (apache#9569) * fix CreateOp of shape related operation to accept dtypes of uint8 and int32 * fix wrong argument y to sequence_length in sequence_reverse's api document * fix wrong argument y to sequence_length in api doc fix wrong argument y to sequence_length in api doc * remove y in api document
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…nd int32 (apache#9569) * fix CreateOp of shape related operation to accept dtypes of uint8 and int32 * fix wrong argument y to sequence_length in sequence_reverse's api document * fix wrong argument y to sequence_length in api doc fix wrong argument y to sequence_length in api doc * remove y in api document
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same context as #9561,
to deal with quantization in future,
operators(sequence_last, sequence_mask, sequence_revert,swapaxis) should have capability to accept uint8 and int32.
Like slice_channel, it can be achieved by changing MSHADOW_REAL_TYPE_SWITCH to MSHADOW_TYPE_SWITCH as concat(https://github.com/apache/incubator-mxnet/blob/d2a856a3a2abb4e72edc301b8b821f0b75f30722/src/operator/concat.cu)
I tested them and it worked well both cpu,gpu setting,
And there was wrong argument y appeared in document of sequence_last,sequence_mask,sequence_reverse instead of right argument sequence_length, so I fixed it also.