This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Temporarily disable test with failing http connection (#9333)" #9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingCat
pushed a commit
to CodingCat/mxnet
that referenced
this pull request
Jan 16, 2018
…#9333)" (apache#9379) This reverts commit 8ad77f3.
yuxiangw
pushed a commit
to yuxiangw/incubator-mxnet
that referenced
this pull request
Jan 25, 2018
…#9333)" (apache#9379) This reverts commit 8ad77f3.
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
…#9333)" (apache#9379) This reverts commit 8ad77f3.
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
…#9333)" (apache#9379) This reverts commit 8ad77f3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8ad77f3.
Description
For the time being the server seems to be stable again, so I'm opening this PR to optionally allow commiters to re-enable the tests.
I feel this test should be refactored such that future web server outages don't break the build. The test seems to be mostly setting up declarative code. During a quick review I noticed that there's for example no asserts in the majority of these tests. It would be great if someone could verify that these tests are actually testing their respective intended units of work.
If merged this addresses issue: #9332