This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Vision] add test cases for flip, normalize, to_tensor #8919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Dec 2, 2017
| @@ -184,26 +184,26 @@ def forward(self, x): | |||
| return image.imresize(x, *self._args) | |||
|
|
|||
|
|
|||
| class RandomHorizontalFlip(HybridBlock): | |||
| """Randomly flip the input image horizontally with a probability | |||
| class RandomLeftRightFlip(HybridBlock): | |||
piiswrong
reviewed
Dec 2, 2017
| f_expect, | ||
| np.random.uniform(0, 255, (300, 300, 3)).astype(dtype=np.uint8)) | ||
|
|
||
| def test_random_top_bottom_flip(): |
There was a problem hiding this comment.
How about run tests on non random versions (flip_left_right, adjust_xxx)
|
I'll add tests for brightness/contrast... once this pr is approved |
piiswrong
reviewed
Dec 9, 2017
| @@ -184,26 +184,44 @@ def forward(self, x): | |||
| return image.imresize(x, *self._args) | |||
|
|
|||
|
|
|||
| class RandomHorizontalFlip(HybridBlock): | |||
| """Randomly flip the input image horizontally with a probability | |||
| class FlipLeftRight(HybridBlock): | |||
There was a problem hiding this comment.
we don't need this for now. It's unclear when you would want to always flip in a transform. We only need the functional implementation flip_left_right
|
Hello @Javelinjs, please rebase your PR. |
|
@marcoabreu You mean rebase from master? Is there anything related to these operators? |
|
Ah my bad, I didn't see you're merging into a different branch. Nevermind :) |
piiswrong
pushed a commit
to piiswrong/mxnet
that referenced
this pull request
Jan 19, 2018
* [vision] ut for to_tensor, normalize, flip * [vision] fix flip * [vision] flip name * [vision] test non-random flip op * remove transform.FlipXXXX
piiswrong
pushed a commit
that referenced
this pull request
Jan 22, 2018
* [vision] ut for to_tensor, normalize, flip * [vision] fix flip * [vision] flip name * [vision] test non-random flip op * remove transform.FlipXXXX
yuxiangw
pushed a commit
to yuxiangw/incubator-mxnet
that referenced
this pull request
Jan 25, 2018
* [vision] ut for to_tensor, normalize, flip * [vision] fix flip * [vision] flip name * [vision] test non-random flip op * remove transform.FlipXXXX
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* [vision] ut for to_tensor, normalize, flip * [vision] fix flip * [vision] flip name * [vision] test non-random flip op * remove transform.FlipXXXX
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* [vision] ut for to_tensor, normalize, flip * [vision] fix flip * [vision] flip name * [vision] test non-random flip op * remove transform.FlipXXXX
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8556