This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Providing explicit null pointer for the provided_arg_stypes. #7791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolivier01
approved these changes
Sep 7, 2017
|
Thank you!!!! |
|
@cjolivier01 Thank you, sorry for original sloppy code, I thought C++ layer will be checking the value of the int and set it to 0, but the C++ code was checking the pointer value instead, my mistake. |
|
If mistakes aren't made, then you probably aren't doing anything new, cool or interesting. |
cjolivier01
pushed a commit
to cjolivier01/mxnet
that referenced
this pull request
Sep 7, 2017
piiswrong
pushed a commit
that referenced
this pull request
Sep 8, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (#7791) * fix wrong dist-kvstore push/pull/rsp_pull (#7762) * rm duplicated and unused code (#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
cjolivier01
pushed a commit
to cjolivier01/mxnet
that referenced
this pull request
Sep 11, 2017
cjolivier01
added a commit
to cjolivier01/mxnet
that referenced
this pull request
Sep 11, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (apache#7791) * fix wrong dist-kvstore push/pull/rsp_pull (apache#7762) * rm duplicated and unused code (apache#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (apache#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 19, 2017
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 19, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (apache#7791) * fix wrong dist-kvstore push/pull/rsp_pull (apache#7762) * rm duplicated and unused code (apache#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (apache#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 19, 2017
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 19, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (apache#7791) * fix wrong dist-kvstore push/pull/rsp_pull (apache#7762) * rm duplicated and unused code (apache#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (apache#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 20, 2017
mbaijal
pushed a commit
to mbaijal/incubator-mxnet
that referenced
this pull request
Sep 20, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (apache#7791) * fix wrong dist-kvstore push/pull/rsp_pull (apache#7762) * rm duplicated and unused code (apache#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (apache#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
crazy-cat
pushed a commit
to crazy-cat/incubator-mxnet
that referenced
this pull request
Oct 26, 2017
crazy-cat
pushed a commit
to crazy-cat/incubator-mxnet
that referenced
this pull request
Oct 26, 2017
* Occasional test failure, reduce testing threshold * Fix signed/unsigned warning * providing explicit null pointer for the provided_arg_stypes. (apache#7791) * fix wrong dist-kvstore push/pull/rsp_pull (apache#7762) * rm duplicated and unused code (apache#7764) * rm not use variables * rm duplicated and unused code * bug * Fix Moderngpu usages in MXNet for CUDA 9 (apache#7789) * Modify ModernGPU for CUDA 9 * Remove unused shfl_up that triggered compiler warning * adjust types to pass to between, add 'const' where possible * Add MSHADOW_CINLINE * lint * Trigger build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eric-haibin-lin @piiswrong @cjolivier01
Instead of introducing a special case to C++ code to work around the bug in perl api, it's better to fix the original bug.
This makes this pull #7783 unnecessary I believe.