Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[scala-package][spark] fix example script #7411

Merged
merged 4 commits into from
Aug 18, 2017

Conversation

CodingCat
Copy link
Contributor

I think it has been broken for a while

and this is one of the fixes which I am bringing to spark module

@CodingCat
Copy link
Contributor Author

@Javelinjs

@CodingCat CodingCat requested a review from yzhliu August 14, 2017 04:29
@CodingCat
Copy link
Contributor Author

@Javelinjs @terrytangyuan any comments on this?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JAR=${MODULE_DIR}/target/mxnet-spark_2.10-0.1.2-SNAPSHOT.jar
if [ "$(uname)" == "Darwin" ]; then
# Do something under Mac OS X platform
OS='osx-x86_64-cpu'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make all indent to 2 spaces?

@yzhliu yzhliu merged commit d2dbffe into apache:master Aug 18, 2017
Guneet-Dhillon pushed a commit to Guneet-Dhillon/mxnet that referenced this pull request Sep 13, 2017
* temp

* temp

* fix example script

* update indent
crazy-cat pushed a commit to crazy-cat/incubator-mxnet that referenced this pull request Oct 26, 2017
* temp

* temp

* fix example script

* update indent
@CodingCat CodingCat deleted the fix_spark_example branch November 21, 2017 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants