Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Replace ReduceToAssign with Reduce #6415

Merged
merged 2 commits into from
May 24, 2017
Merged

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented May 24, 2017

This PR should fix this issue.
#6324 (comment)

Test script:

 import mxnet as mx
 import time
 
 data = mx.sym.Variable('data')
 sym = mx.sym.broadcast_to(data, shape=(62, 2048, 14, 14))
 exe = sym.simple_bind(ctx=mx.gpu(0), data=(62, 2048, 1, 1)) 
 
 exe.forward(is_train=True)
 exe.backward(out_grads=exe.outputs[0])
 time.sleep(3)  #https://github.com/dmlc/mxnet/issues/1137

@piiswrong @eric-haibin-lin @madjam please review.

@piiswrong
Copy link
Contributor

Did you remove all reference to ReduceToAssign? If so could you remove the function alltogether?

@@ -267,8 +267,6 @@ void BinaryBroadcastBackwardUseIn(const nnvm::NodeAttrs& attrs,
}
}

#undef BROADCAST_NDIM_SWITCH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line prevents me from using this macro in broadcast_reduce_op.h. So I had to remove it.

I will remove the function definitions of ReduceToAssign.

@piiswrong piiswrong merged commit 301f712 into apache:master May 24, 2017
Guneet-Dhillon pushed a commit to Guneet-Dhillon/mxnet that referenced this pull request Sep 13, 2017
* Replace ReduceToAssign

* Remove ReduceToAssign
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants