This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix NDArrayGetData to return to use the right datatype #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like python is not using this function? |
|
LGTM. Why is there a perl_test in travis CI? |
|
I will need the maintainers for the Perl and C++ frontend to have a look at this. |
piiswrong
reviewed
Mar 31, 2017
| MXNDArrayGetDType(blob_ptr_->handle, &ret); | ||
| return ret; | ||
| } | ||
|
|
||
| inline const mx_float *NDArray::GetData() const { |
There was a problem hiding this comment.
@lx75249 let's change this to
template<typename DType = mx_float>
inline const DType *NDArray::GetData() const {}
Guneet-Dhillon
pushed a commit
to Guneet-Dhillon/mxnet
that referenced
this pull request
Sep 13, 2017
* fix NDArrayGetData to return to use the right datatype * try to address C++ and Perl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failed if one tried to get the underlying data pointer for a NDArray with a dtype other then
Float32.I don't know if any of the other packages need to be adapted. I discovered this while working on the Julia package.
cc: @pluskid