Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[scala-package] fix the "too-wide" accessibilities of scala classes (mxnet-core) #5485

Merged
merged 12 commits into from
Mar 22, 2017

Conversation

CodingCat
Copy link
Contributor

When going through the code of mxnet-core, I found that the accessibility of some classes are too wide, i.e. these classes shall not be exposed to the external usage

I cleaned these in this PR

the other changes include

  1. remove some author tags (as they are not allowed in ASF projects)

  2. change the package name of examples from mxnet.examples to mxnetexamples: this change will make the development of examples in a full perspective of an external user, and it also helps to ensure that we are not mistakenly narrow the accessibilities

@Javelinjs @Ldpe2G would you mind helping to review?

@Ldpe2G
Copy link
Contributor

Ldpe2G commented Mar 20, 2017

@CodingCat
Copy link
Contributor Author

@Ldpe2G thanks for reminding this, just committed the changes

@piiswrong
Copy link
Contributor

is this good for merge?

@Ldpe2G
Copy link
Contributor

Ldpe2G commented Mar 22, 2017

@Javelinjs

@yzhliu yzhliu merged commit 16df941 into apache:master Mar 22, 2017
@CodingCat
Copy link
Contributor Author

thanks

@CodingCat CodingCat deleted the code_clean_up branch November 21, 2017 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants