update BM to use MKL BM V2 API #3953

glingyan · 2016-11-23T13:54:15Z

only compilable for MKL release after 1115

Signed-off-by: lingyan lingyan.guo@intel.com

only compilable for MKL release after 1115 Signed-off-by: lingyan <lingyan.guo@intel.com>

piiswrong · 2016-11-24T00:42:20Z

Please ping my after you fixed the path issue and we can merge

move old mkl version to ~/mklml_release/mkl_$version automatically Signed-off-by: lingyan <lingyan.guo@intel.com>

glingyan · 2016-11-30T01:18:40Z

hi Eric: any update ?

piiswrong · 2016-11-30T17:21:37Z

Is path fixed here? Also could you add the old version back to webdata? Its causing 404 errors for people with old code

please rebase

glingyan · 2016-11-30T23:47:09Z

yes，will add keep old release on from now on 发自我的 iPhone 在 2016年12月1日，上午1:22，Eric Junyuan Xie <notifications@github.com<mailto:notifications@github.com>> 写道： Is path fixed here? Also could you add the old version back to webdata? Its causing 404 errors for people with old code — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3953 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVcrhZi46uL2YmEcjFrQ8551iZakBnJzks5rDbCygaJpZM4K6mg1>.

glingyan · 2016-12-01T00:57:21Z

1. Path problem solved, as I said , it will rename old mkl version to mkl_<version number> dir to backup 2. Please check new web_data pull request at dmlc/web-data#14 From: Eric Junyuan Xie [mailto:notifications@github.com] Sent: Thursday, December 1, 2016 1:22 AM To: dmlc/mxnet <mxnet@noreply.github.com> Cc: Guo, Lingyan <lingyan.guo@intel.com>; Author <author@noreply.github.com> Subject: Re: [dmlc/mxnet] update BM to use MKL BM V2 API (#3953) Is path fixed here? Also could you add the old version back to webdata? Its causing 404 errors for people with old code — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3953 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVcrhZi46uL2YmEcjFrQ8551iZakBnJzks5rDbCygaJpZM4K6mg1>.

piiswrong · 2016-12-01T06:08:21Z

So it gets downloaded to root now? Is there any documentation that mention this change?
Why not put mklroot in config.mk? Also the instruction for setting mklroot and LD_LIBRARY_PATH should be in config.mk. Its better if the user can, for example, set mklroot=/usr/local and install it to /usr/local/include and /usr/local/lib

glingyan · 2016-12-01T06:23:19Z

Enable USE_MKL2017=1 in make/config.mk

1.1 USE_BLAS should be atlas by default

1.2 if you need USE_BLAS to be mkl, please navigate here to do a full MKL installation: https://registrationcenter.intel.com/en/forms/?productid=2558&licensetype=2

1.3 By default, MKL_2017_EXPRIEMENTAL=0. If setting MKL_2017_EXPRIEMENTAL=1, MKL buffer will be created and transferred between layers to achiever much higher performance.

Run 'make -jX'

2.1 Makefile will execute "prepare_mkl.sh" to download the mkl under ~/mklml_release/mklml folder

    2.2.1 if previous mkl version exist, e.g. previous mkl is 20120601, ~/mklml_release/mklml will rename to ~/mklml_release/mklml.20120601
    
        2.2.1.1 if previous mkl is 20120601 and mklml.20120601 is exist, this is unlikely to happen ,default behaviour is remove mklml to avoid compiling error

2.2 if the download failed because of proxy setting, please download it manually before make

2.2.1 wget https://github.com/dmlc/web-data/raw/master/mxnet/mklml-release/mklml_lnx_<MKL VERSION>.tgz

2.2.2 tar zxvf mklml_lnx_<MKL VERSION>.tgz

2.2.3 mv mklml_lnx_<MKL VERSION> ~/mklml_release/mklml

   2.2.3.1 mkdir mklml_release if not exists

Navigate into the python directory

glingyan · 2016-12-01T06:23:34Z

will checkin soon

glingyan · 2016-12-01T06:26:23Z

put mklroot in config.mk is a good idea, will check then

piiswrong · 2016-12-01T06:26:35Z

Also pooling still fails. Could you fallback to mxnet implementation for pooling until its fixed for mkl?

piiswrong · 2016-12-01T06:28:44Z

@glingyan Also keep the tar.gz under mxnet, extract it to mklroot and remove the superfluous directory hierachies. So MKLROOT=~ to lead to things extracted to ~/include/mkl_xxx.h and ~/lib/libmklxxx.so

piiswrong · 2016-12-01T06:30:23Z

Please simplify the intructions in MKL_README and put it in config.mk under the relevent variables

glingyan · 2016-12-01T06:39:53Z

是不是将MKL_README 放在make 目录,和config.mk同目录? From: Eric Junyuan Xie [mailto:notifications@github.com] Sent: Thursday, December 1, 2016 2:31 PM To: dmlc/mxnet <mxnet@noreply.github.com> Cc: Guo, Lingyan <lingyan.guo@intel.com>; Mention <mention@noreply.github.com> Subject: Re: [dmlc/mxnet] update BM to use MKL BM V2 API (#3953) Please simplify the intructions in MKL_README and put it in config.mk under the relevent variables — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3953 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVcrhcjWcp7pzk_3VwtoyoeyP--g13gNks5rDmmLgaJpZM4K6mg1>.

Signed-off-by: lingyan <lingyan.guo@intel.com>

This reverts commit 9d97746.

glingyan · 2016-12-02T05:21:37Z

MKLML_ROOT feature done
MKL_README.mk updated and move to make folder , the same folder with config.mk

piiswrong · 2016-12-02T05:24:47Z

make/config.mk

@@ -59,6 +59,9 @@ USE_OPENCV = 1
 # use openmp for parallelization


Sorry for not being clear. I didn't mean to move MKL_README to make/. I meant picking out the relevant sentences and put them here.
The MKLML_ROOT, USE_MKL2016 and UES_MKL_EXPERIMENTAL options should have detailed explanation of what they do. Or at least point the user to MKL_README for more details

piiswrong · 2016-12-02T05:26:06Z

prepare_mkl.sh

+      wget --no-check-certificate -P $MXNET_ROOT $MKLURL -O $MXNET_ROOT/$ARCHIVE_BASENAME
+      tar -xzf $MXNET_ROOT/$ARCHIVE_BASENAME -C $MXNET_ROOT
+      #echo $HOME_MKL
+      yes | cp -rf $MXNET_ROOT/$MKL_CONTENT_DIR/* $HOME_MKL


Have you confirmed this works? Do you need sudo cp?

I tested:

root user, put it in /usr/local

normal user, put it in ~
but for sudo , it is hard to do , becuase makefile need to get output from prepare_mkl.sh
if need sudo to input password, it will not work
do you have seem any solution for this?

Signed-off-by: lingyan <lingyan.guo@intel.com>

glingyan · 2016-12-05T14:20:55Z

Support Pooling Asymmetric padding filled by zeros , it will pass the test when cudnn use CUDNN_POOLING_AVERAGE_COUNT_EXCLUDE_PADDING mode

piiswrong · 2016-12-05T19:04:15Z

src/operator/pooling-inl.h

@@ -50,13 +48,6 @@ struct PoolingParam : public dmlc::Parameter<PoolingParam> {
    .add_enum("sum", pool_enum::kSumPooling)
    .describe("Pooling type to be applied.");

-    DMLC_DECLARE_FIELD(pooling_convention).set_default(pool_enum::kValid)


why did you remove this?

this is include by MKL2017 implemented layers integration to improve IA perf. on mxnet (#3581)
at that time , mkl pooling do not support Asymmetric padding filled by zeros, by default pool_enum::kValid will use mxnet pooling implmenetation

pooling_convention is a useful option. We should keep it

glingyan · 2016-12-06T01:50:55Z

New patch upload, add pooling_convention again From: Eric Junyuan Xie [mailto:notifications@github.com] Sent: Tuesday, December 6, 2016 8:21 AM To: dmlc/mxnet <mxnet@noreply.github.com> Cc: Guo, Lingyan <lingyan.guo@intel.com>; Mention <mention@noreply.github.com> Subject: Re: [dmlc/mxnet] update BM to use MKL BM V2 API (#3953) @piiswrong commented on this pull request.

________________________________ In src/operator/pooling-inl.h<#3953>:

@@ -50,13 +48,6 @@ struct PoolingParam : public dmlc::Parameter<PoolingParam> {

.add_enum("sum", pool_enum::kSumPooling) .describe("Pooling type to be applied."); - DMLC_DECLARE_FIELD(pooling_convention).set_default(pool_enum::kValid) pooling_convention is a useful option. We should keep it — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3953>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVcrhQG0sh5WH2Tb0L8rPvLk9eIhIXFQks5rFKp_gaJpZM4K6mg1>.

piiswrong · 2016-12-06T19:06:43Z

Please rebase,
make the comment in config.mk more descriptive (atleast "Please refer to MKL_README.md for details)
verify that test_operator_gpu passes when mkl is on
and we can merge

glingyan · 2016-12-07T01:17:31Z

done, please check #4128

futurely · 2016-12-13T08:02:20Z

This PR should be closed since #4128 has been merged.

glingyan · 2016-12-13T08:08:55Z

How to close it if the original repo is deleted? From: futurely [mailto:notifications@github.com] Sent: Tuesday, December 13, 2016 4:03 PM To: dmlc/mxnet <mxnet@noreply.github.com> Cc: Guo, Lingyan <lingyan.guo@intel.com>; Mention <mention@noreply.github.com> Subject: Re: [dmlc/mxnet] update BM to use MKL BM V2 API (#3953) This PR should be closed since #4128<#4128> has been merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3953 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AVcrhRV5dG_z5FLzf08ddTS1LfOA34bwks5rHlEXgaJpZM4K6mg1>.

update BM to use MKL BM V2 API

63ea2bc

only compilable for MKL release after 1115 Signed-off-by: lingyan <lingyan.guo@intel.com>

uncompression mkl release to ~/mklml_release/mkl by default

0fecbb9

move old mkl version to ~/mklml_release/mkl_$version automatically Signed-off-by: lingyan <lingyan.guo@intel.com>

glingyan added 4 commits December 1, 2016 16:07

Use MKLML_ROOT=/usr/local(by default) to assign MKL_ML default library

0d3d5dc

Signed-off-by: lingyan <lingyan.guo@intel.com>

move MKL_README.md to make folder

9d97746

Signed-off-by: lingyan <lingyan.guo@intel.com>

change Makefile to use MKLML_ROOT as default MKL_ML library path

b5297b6

Signed-off-by: lingyan <lingyan.guo@intel.com>

Revert "move MKL_README.md to make folder"

3c4f82a

This reverts commit 9d97746.

piiswrong reviewed Dec 2, 2016

View reviewed changes

glingyan added 3 commits December 4, 2016 12:17

support Asymmetric padding filled by zeros in pooling

ee571df

Signed-off-by: lingyan <lingyan.guo@intel.com>

revert pooling_convention feature

7d39a04

Signed-off-by: lingyan <lingyan.guo@intel.com>

owqnly use mkl avg Pool when pool_conversion is kFull

503cebd

Signed-off-by: lingyan <lingyan.guo@intel.com>

piiswrong reviewed Dec 5, 2016

View reviewed changes

This was referenced Dec 6, 2016

fix make error #4038

Closed

Adding USE_MKL2017 option to cmake build #4014

Closed

piiswrong closed this Dec 13, 2016

zhouphd mentioned this pull request Jan 4, 2017

[MakeFile Error] USE_MKL2017 for performance, undefined reference to `dnnBatchNormalizationCreateBackward_v2_F32' #4505

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update BM to use MKL BM V2 API #3953

update BM to use MKL BM V2 API #3953

glingyan commented Nov 23, 2016

piiswrong commented Nov 24, 2016

glingyan commented Nov 30, 2016

piiswrong commented Nov 30, 2016 •

edited

Loading

glingyan commented Nov 30, 2016 via email

glingyan commented Dec 1, 2016 via email

piiswrong commented Dec 1, 2016 •

edited

Loading

glingyan commented Dec 1, 2016

glingyan commented Dec 1, 2016

glingyan commented Dec 1, 2016

piiswrong commented Dec 1, 2016

piiswrong commented Dec 1, 2016

piiswrong commented Dec 1, 2016

glingyan commented Dec 1, 2016 via email

glingyan commented Dec 2, 2016

piiswrong Dec 2, 2016

piiswrong Dec 2, 2016

glingyan Dec 2, 2016

glingyan commented Dec 5, 2016

piiswrong Dec 5, 2016

glingyan Dec 5, 2016

piiswrong Dec 6, 2016

glingyan commented Dec 6, 2016 via email

piiswrong commented Dec 6, 2016 •

edited

Loading

glingyan commented Dec 7, 2016

futurely commented Dec 13, 2016

glingyan commented Dec 13, 2016 via email

		@@ -59,6 +59,9 @@ USE_OPENCV = 1
		# use openmp for parallelization

update BM to use MKL BM V2 API #3953

update BM to use MKL BM V2 API #3953

Conversation

glingyan commented Nov 23, 2016

piiswrong commented Nov 24, 2016

glingyan commented Nov 30, 2016

piiswrong commented Nov 30, 2016 • edited Loading

glingyan commented Nov 30, 2016 via email

glingyan commented Dec 1, 2016 via email

piiswrong commented Dec 1, 2016 • edited Loading

glingyan commented Dec 1, 2016

glingyan commented Dec 1, 2016

glingyan commented Dec 1, 2016

piiswrong commented Dec 1, 2016

piiswrong commented Dec 1, 2016

piiswrong commented Dec 1, 2016

glingyan commented Dec 1, 2016 via email

glingyan commented Dec 2, 2016

piiswrong Dec 2, 2016

Choose a reason for hiding this comment

piiswrong Dec 2, 2016

Choose a reason for hiding this comment

glingyan Dec 2, 2016

Choose a reason for hiding this comment

glingyan commented Dec 5, 2016

piiswrong Dec 5, 2016

Choose a reason for hiding this comment

glingyan Dec 5, 2016

Choose a reason for hiding this comment

piiswrong Dec 6, 2016

Choose a reason for hiding this comment

glingyan commented Dec 6, 2016 via email

piiswrong commented Dec 6, 2016 • edited Loading

glingyan commented Dec 7, 2016

futurely commented Dec 13, 2016

glingyan commented Dec 13, 2016 via email

piiswrong commented Nov 30, 2016 •

edited

Loading

piiswrong commented Dec 1, 2016 •

edited

Loading

piiswrong commented Dec 6, 2016 •

edited

Loading