Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add RNN model in R #2417

Merged
merged 5 commits into from
Jun 18, 2016
Merged

Add RNN model in R #2417

merged 5 commits into from
Jun 18, 2016

Conversation

ziyeqinghan
Copy link
Contributor

I add Custom RNN model and some high-level reusable APIs is provided which is similar to the APIs for LSTM in [#2329]

  • mx.rnn Training RNN Unrolled Model
  • mx.rnn.inference Create a RNN Inference Model
  • mx.rnn.forward Forward function for RNN inference model

@tqchen
Copy link
Member

tqchen commented Jun 16, 2016

@thirdwing can you review this?

@ziyeqinghan ziyeqinghan force-pushed the master branch 2 times, most recently from 33b8de2 to 0bdd7f5 Compare June 17, 2016 05:42
@thirdwing
Copy link
Contributor

LGTM. This is mostly refactoring work.

Sorry for the delay. I was caught in a bad cold while in Texas.

@terrytangyuan I will merge this if you agree.

@terrytangyuan
Copy link
Member

@thirdwing Go ahead. Looks good. @ziyeqinghan You might need to rebase.

@thirdwing thirdwing mentioned this pull request Jun 17, 2016
@ziyeqinghan
Copy link
Contributor Author

The branch is rebased.

@tqchen tqchen merged commit 3bd0c61 into apache:master Jun 18, 2016
zjf pushed a commit to zjf/mxnet that referenced this pull request Jun 18, 2016
* refactor lstm model to seperate reusable rnn function like training from lstm model

* add Custom RNN model in R

* modify the documentation to add explanation of RNN and fix some typos

* remove some unuseful comments

* fix typo
tqchen pushed a commit that referenced this pull request Jun 18, 2016
* Update warpctc-inl.h

avoid compile error in cpu-only mode

* [OP] Support softmax with probability label (#2456)

* don't run char rnn test in R (#2459)

* [OP] add slice_axis (#2458)

* [OP] add slice

* optimization

* fix some typos (#2450)

* add warpctc config to config.mk (#2451)

* update lstm.py reshape using shape (#2446)

changing target_shape to shape

* fix worker node could not exit (#2440)

* add target_shape and adj to deconv for friendly using (#2445)

* add target_shape and adj to deconv for friendly using

* fix typo

* Add RNN model in R (#2417)

* refactor lstm model to seperate reusable rnn function like training from lstm model

* add Custom RNN model in R

* modify the documentation to add explanation of RNN and fix some typos

* remove some unuseful comments

* fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants