Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[API NEW][METHOD] Add mT, permute_dims #20688

Merged
szha merged 7 commits into from
Oct 30, 2021
Merged

[API NEW][METHOD] Add mT, permute_dims #20688

szha merged 7 commits into from
Oct 30, 2021

Conversation

@barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Oct 21, 2021

Description

Add mT and permute_dims

Specified in Array-API-Standardization:

  • permute_dims is alias for transpose
  • mT is the property which returns the matrix_transpose of itself.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@barry-jin barry-jin requested a review from szha as a code owner October 21, 2021 21:52
@mxnet-bot
Copy link

mxnet-bot commented Oct 21, 2021

Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, centos-gpu, clang, centos-cpu, unix-cpu, sanity, unix-gpu, website, edge, windows-cpu, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 21, 2021
@barry-jin barry-jin mentioned this pull request Oct 21, 2021
Open
52 tasks
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 21, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 22, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 22, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 22, 2021

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 22, 2021

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2021
szha
szha reviewed Oct 27, 2021
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the test for this already enabled?

@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 27, 2021

is the test for this already enabled?

Not yet. I will add later.

@barry-jin barry-jin changed the title [API] Add mT, permute_dims [WIP][API] Add mT, permute_dims Oct 27, 2021
@mseth10 mseth10 removed the pr-awaiting-review PR is waiting for code review label Oct 27, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 27, 2021
@mseth10 mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 27, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 28, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, website]

@mxnet-bot
Copy link

mxnet-bot commented Oct 28, 2021

Jenkins CI successfully triggered : [unix-gpu, website, unix-cpu, centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@barry-jin barry-jin changed the title [API] Add mT, permute_dims [API NEW][METHOD] Add mT, permute_dims Oct 28, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 28, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 28, 2021

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 28, 2021
@barry-jin
Copy link
Contributor Author

barry-jin commented Oct 29, 2021

@mxnet-bot run ci [centos-gpu, unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Oct 29, 2021

Jenkins CI successfully triggered : [centos-gpu, unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 29, 2021
@szha szha merged commit 1a1464f into apache:master Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@szha szha szha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barry-jin @mxnet-bot @szha @mseth10