Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[PIP] update manifest to include lib_api.cc #19850

Merged
szha merged 3 commits into from
Feb 7, 2021
Merged

[PIP] update manifest to include lib_api.cc #19850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3532b8
update manifest to include lib_api.cc
Feb 5, 2021
958ad7f
add cc
Feb 5, 2021
bfdfdf7
fix lib_api.cc packaging
Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/pip/MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ recursive-include mxnet *_LICENSE
recursive-include mxnet *.h
recursive-include mxnet *.hpp
recursive-include mxnet *.cuh
recursive-include mxnet *.cc
recursive-include mxnet *.cpp
Copy link
Contributor

@samskalicky samskalicky Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does *.cpp include *.cc files?
https://github.com/apache/incubator-mxnet/blob/master/src/lib_api.cc

Copy link
Member Author

@szha szha Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, let me include cc as well.

Copy link
Contributor

@samskalicky samskalicky Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, were you able to package the wheel and unzip it and confirm the lib_api.cc was inside?

recursive-include dmlc_tracker *.py
1 change: 1 addition & 0 deletions tools/pip/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
os.path.join(CURRENT_DIR, 'mxnet/include/nnvm'))

# copy cc file for mxnet extensions
os.mkdir(os.path.join(CURRENT_DIR, 'mxnet/src'))
shutil.copy(os.path.join(CURRENT_DIR, 'mxnet-build/src/lib_api.cc'),
os.path.join(CURRENT_DIR, 'mxnet/src'))

Expand Down