-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[v1.x] Static build for mxnet-cu110 #19272
Conversation
|
Hey @waytrue17 , Thanks for submitting the PR
CI supported jobs: [sanity, miscellaneous, windows-cpu, unix-gpu, centos-gpu, website, windows-gpu, unix-cpu, clang, edge, centos-cpu] Note: |
|
@leezu @ChaiBapchya Can you please review this PR? |
|
Thank you so much @waytrue17 |
|
How & Where has this change been tested? |
I am testing it by calling |
ChaiBapchya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. thanks & hope we confirmed ldd libmxnet.so is linked to cuda11 so
@ChaiBapchya Thanks for the suggestion. The following is the |
* static build with cuda 11.0 * add newline at the end of files, add set -e * add new line Co-authored-by: Wei Chu <weichu@amazon.com>
|
@waytrue17 could you also port this to master once merged? It will help resolve #18657 (comment) |
szha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more missing items:
- CMake config in https://github.com/apache/incubator-mxnet/tree/v1.x/config/distribution
- pip package description doc in https://github.com/apache/incubator-mxnet/tree/v1.x/tools/pip/doc
|
Remember to also configure the CD pipeline for a nightly build of this variant for testing. https://jenkins.mxnet-ci.amazon-ml.com/job/restricted-mxnet-cd/ |
|
Looks like CUDA 11.1 is available now and we should consider adding that too. |
opened a separate PR for master branch:#19295 |
@szha Added the missing items and also configured the cd tests. Please review again, thanks |
|
@mxnet-bot run ci [centos-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu] |
|
@mxnet-bot run ci [sanity] |
|
Jenkins CI successfully triggered : [sanity] |
mseth10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added static build MXNet with CUDA 11.0
Checklist
Essentials
Changes